liurenjie1024 closed pull request #62: feat: add builder to TableMetadata
interface
URL: https://github.com/apache/iceberg-rust/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
liurenjie1024 commented on PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-2014886303
> cc @y0psolo Should we close this now? I think it's resolved by #262
I'll close this for now, feel free to reopen it if necessary.
--
This is an automated message from the
liurenjie1024 commented on PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-2012426148
cc @y0psolo Should we close this now? I think it's resolved by #262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
y0psolo commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1366870135
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +116,278 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the list.
y0psolo commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1363494936
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +116,278 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the list.
liurenjie1024 commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1363528032
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +116,278 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the
y0psolo commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1363494936
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +116,278 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the list.
y0psolo commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1363494936
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +116,278 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the list.
liurenjie1024 commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1357880510
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +116,278 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the
liurenjie1024 commented on PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1751887344
> I don't know yet if we should remove the builder as it seems to provide
some internal struct builder and default value at least. We will see with what
is left at the end under h
y0psolo commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1349568117
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +112,291 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the list.
y0psolo commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1349567865
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +112,291 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the list.
y0psolo commented on PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1751805399
> Hi, @y0psolo Thanks for the effort! But I'm a little worried about the api
here, since it's error prone, e.g. it's quite easy to construct an invalid
table metadata. My suggestion woul
liurenjie1024 commented on PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1751587849
Hi, @y0psolo Thanks for the effort! But I'm a little worried about the api
here, since it's error prone, e.g. it's quite easy to construct an invalid
table metadata. My suggestion
liurenjie1024 commented on code in PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#discussion_r1349453405
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -93,22 +112,291 @@ pub struct TableMetadata {
/// previous metadata file location should be added to the
y0psolo commented on PR #62:
URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1749197704
Ok i added some validation steps. Tell me if its ok
i don't know if we need to have all fields visible on the builder. Tell me.
We can choose to open and restrict later or do the rever
16 matches
Mail list logo
