liurenjie1024 commented on PR #62: URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1751887344
> I don't know yet if we should remove the builder as it seems to provide some internal struct builder and default value at least. We will see with what is left at the end under his responsability. The reason why I suggest removing derived builder is that `TableMetadata` is a quite complex data structure, also a core data structure for iceberg. Derived builder makes it quite difficult for reviewers to identify what's auto generated implicitly. As we reached an agreement that most public apis should follow java's builder implementation, I don't think that it's still useful to leave it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
