Re: [PR] feat: add asan and ubsan support to cmake [iceberg-cpp]

2025-05-23 Thread via GitHub
raulcd commented on code in PR #107: URL: https://github.com/apache/iceberg-cpp/pull/107#discussion_r2104144654 ## .github/workflows/sanitizer_test.yml: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] feat: add asan and ubsan support to cmake [iceberg-cpp]

2025-05-22 Thread via GitHub
lidavidm commented on code in PR #107: URL: https://github.com/apache/iceberg-cpp/pull/107#discussion_r2103733217 ## .github/workflows/sanitizer_test.yml: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] feat: add asan and ubsan support to cmake [iceberg-cpp]

2025-05-22 Thread via GitHub
wgtmac commented on PR #107: URL: https://github.com/apache/iceberg-cpp/pull/107#issuecomment-2903140398 ``` [ 0%] Building C object _deps/nanoarrow-build/CMakeFiles/nanoarrow.dir/src/nanoarrow/common/array.c.o cd /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/nanoarrow-build &

Re: [PR] feat: add asan and ubsan support to cmake [iceberg-cpp]

2025-05-22 Thread via GitHub
wgtmac commented on PR #107: URL: https://github.com/apache/iceberg-cpp/pull/107#issuecomment-2903123846 @lidavidm @raulcd Could you help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat: add asan and ubsan support to cmake [iceberg-cpp]

2025-05-22 Thread via GitHub
wgtmac commented on code in PR #107: URL: https://github.com/apache/iceberg-cpp/pull/107#discussion_r2102015141 ## CMakeLists.txt: ## @@ -37,6 +37,8 @@ option(ICEBERG_BUILD_STATIC "Build static library" ON) option(ICEBERG_BUILD_SHARED "Build shared library" OFF) option(ICEBERG

[PR] feat: add asan and ubsan support to cmake [iceberg-cpp]

2025-05-22 Thread via GitHub
METONLIULEI opened a new pull request, #107: URL: https://github.com/apache/iceberg-cpp/pull/107 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe