wgtmac commented on PR #107:
URL: https://github.com/apache/iceberg-cpp/pull/107#issuecomment-2903140398
```
[ 0%] Building C object
_deps/nanoarrow-build/CMakeFiles/nanoarrow.dir/src/nanoarrow/common/array.c.o
cd /home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/nanoarrow-build &&
/usr/bin/cc -DNANOARROW_DEBUG
-I/home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/nanoarrow-src/src
-I/home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/nanoarrow-build/src -g
-std=gnu99 -fPIC -fsanitize=address -fno-omit-frame-pointer
-fsanitize=undefined -Wall -Werror -Wextra -Wpedantic -Wno-type-limits
-Wmaybe-uninitialized -Wunused-result -Wconversion -Wno-sign-conversion
-Wno-misleading-indentation -MD -MT
_deps/nanoarrow-build/CMakeFiles/nanoarrow.dir/src/nanoarrow/common/array.c.o
-MF CMakeFiles/nanoarrow.dir/src/nanoarrow/common/array.c.o.d -o
CMakeFiles/nanoarrow.dir/src/nanoarrow/common/array.c.o -c
/home/runner/work/iceberg-cpp/iceberg-cpp/build/_deps/nanoarrow-src/src/nanoarrow/common/array.c
```
It seems that the flags for sanitizers are leaked into thirdparty builds. We
need to use target-based compile properties like below:
```
add_library(iceberg_sanitizer_flags INTERFACE)
set(SANITIZER_FLAGS "-fsanitize=address,undefined")
target_compile_options(iceberg_sanitizer_flags INTERFACE ${SANITIZER_FLAGS})
target_link_options(iceberg_sanitizer_flags INTERFACE ${SANITIZER_FLAGS})
target_link_libraries(xxx PRIVATE iceberg_sanitizer_flags)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
