Re: [PR] feat: SortOrder methods should take schema ref if possible [iceberg-rust]

2024-09-08 Thread via GitHub
Xuanwo commented on code in PR #613: URL: https://github.com/apache/iceberg-rust/pull/613#discussion_r1749260477 ## crates/iceberg/src/spec/sort.rs: ## @@ -133,6 +133,14 @@ impl SortOrder { pub fn is_unsorted(&self) -> bool { self.fields.is_empty() } + +//

[PR] feat: SortOrder methods should take schema ref if possible [iceberg-rust]

2024-09-08 Thread via GitHub
c-thiel opened a new pull request, #613: URL: https://github.com/apache/iceberg-rust/pull/613 Reduce clones I also added two tests that didn't fail but where missing IMO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a