Xuanwo commented on code in PR #613:
URL: https://github.com/apache/iceberg-rust/pull/613#discussion_r1749260477
##########
crates/iceberg/src/spec/sort.rs:
##########
@@ -133,6 +133,14 @@ impl SortOrder {
pub fn is_unsorted(&self) -> bool {
self.fields.is_empty()
}
+
+ /// Set the order id for the sort order
+ pub fn with_order_id(&self, order_id: i64) -> SortOrder {
Review Comment:
An API named `with_xxx` that takes a ref might be a bit confusing. Is there
any context for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
