Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-08 Thread via GitHub
Fokko commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1386224255 ## crates/iceberg/src/table.rs: ## @@ -17,10 +17,33 @@ //! Table API for Apache Iceberg +use crate::io::FileIO; use crate::spec::TableMetadata; +use crate::TableId

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-08 Thread via GitHub
Fokko merged PR #89: URL: https://github.com/apache/iceberg-rust/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-08 Thread via GitHub
Fokko commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1386222676 ## crates/catalog/rest/src/catalog.rs: ## @@ -312,11 +316,43 @@ impl Catalog for RestCatalog { } /// Load table from the catalog. -async fn load_table(&s

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-02 Thread via GitHub
liurenjie1024 commented on PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#issuecomment-1791793211 CC @Xuanwo @Fokko Any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-02 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1379743215 ## crates/iceberg/src/table.rs: ## @@ -17,10 +17,33 @@ //! Table API for Apache Iceberg +use crate::io::FileIO; use crate::spec::TableMetadata; +use crate:

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-01 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378534267 ## crates/catalog/rest/src/catalog.rs: ## @@ -312,11 +316,43 @@ impl Catalog for RestCatalog { } /// Load table from the catalog. -async fn load_

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-01 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378532556 ## crates/catalog/rest/src/catalog.rs: ## @@ -312,11 +316,43 @@ impl Catalog for RestCatalog { } /// Load table from the catalog. -async fn load_

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-01 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378523841 ## crates/iceberg/src/table.rs: ## @@ -17,10 +17,33 @@ //! Table API for Apache Iceberg +use crate::io::FileIO; use crate::spec::TableMetadata; +use crate:

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-01 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378522771 ## crates/catalog/rest/src/catalog.rs: ## @@ -312,11 +316,43 @@ impl Catalog for RestCatalog { } /// Load table from the catalog. -async fn load_

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-11-01 Thread via GitHub
Fokko commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1377882393 ## crates/catalog/rest/src/catalog.rs: ## @@ -312,11 +316,43 @@ impl Catalog for RestCatalog { } /// Load table from the catalog. -async fn load_table(&s

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-10-31 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378337379 ## crates/iceberg/src/spec/table_metadata.rs: ## @@ -109,50 +110,139 @@ pub struct TableMetadata { } impl TableMetadata { +/// Returns format version of

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-10-31 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378335610 ## crates/iceberg/src/spec/table_metadata.rs: ## @@ -109,50 +110,139 @@ pub struct TableMetadata { } impl TableMetadata { +/// Returns format version of

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-10-31 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378335162 ## crates/iceberg/src/spec/table_metadata.rs: ## @@ -109,50 +110,139 @@ pub struct TableMetadata { } impl TableMetadata { +/// Returns format version of

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-10-31 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378334579 ## crates/iceberg/src/spec/table_metadata.rs: ## @@ -109,50 +110,139 @@ pub struct TableMetadata { } impl TableMetadata { +/// Returns format version of

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-10-31 Thread via GitHub
liurenjie1024 commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1378325205 ## crates/catalog/rest/src/catalog.rs: ## @@ -312,11 +316,43 @@ impl Catalog for RestCatalog { } /// Load table from the catalog. -async fn load_

Re: [PR] feat: Implement load table api. [iceberg-rust]

2023-10-31 Thread via GitHub
Xuanwo commented on code in PR #89: URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1377416089 ## crates/catalog/rest/src/catalog.rs: ## @@ -312,11 +316,43 @@ impl Catalog for RestCatalog { } /// Load table from the catalog. -async fn load_table(&

[PR] feat: Implement load table api. [iceberg-rust]

2023-10-30 Thread via GitHub
liurenjie1024 opened a new pull request, #89: URL: https://github.com/apache/iceberg-rust/pull/89 This pr implements load table in rest catalog, also add accesses to table metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi