liurenjie1024 commented on code in PR #89:
URL: https://github.com/apache/iceberg-rust/pull/89#discussion_r1379743215
##########
crates/iceberg/src/table.rs:
##########
@@ -17,10 +17,33 @@
//! Table API for Apache Iceberg
+use crate::io::FileIO;
use crate::spec::TableMetadata;
+use crate::TableIdent;
+use typed_builder::TypedBuilder;
/// Table represents a table in the catalog.
+#[derive(TypedBuilder)]
pub struct Table {
- metadata_location: String,
+ file_io: FileIO,
+ #[builder(default, setter(strip_option))]
+ metadata_location: Option<String>,
metadata: TableMetadata,
+ identifier: TableIdent,
+}
+
+impl Table {
+ /// Returns table identifier.
Review Comment:
Oh, you mean reference to `Catalog`? If so, this may not be desirable since
it add life time of `Catalog` instance to `Table`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
