liurenjie1024 merged PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Xuanwo commented on PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#issuecomment-2540876657
cc @Fokko, would you like to take another? I believe it's good for merging
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
Xuanwo commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1879569854
##
crates/iceberg/src/spec/values.rs:
##
@@ -1012,6 +1053,33 @@ impl Datum {
}
}
+/// Try to create a decimal literal from [`Decimal`] with precis
liurenjie1024 commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1875657680
##
crates/iceberg/src/spec/values.rs:
##
@@ -1012,6 +1053,33 @@ impl Datum {
}
}
+/// Try to create a decimal literal from [`Decimal`] with
Xuanwo commented on PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#issuecomment-2522777447
cc @liurenjie1024 and @Fokko to take another look, sorry for the long wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
Xuanwo commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1873003768
##
crates/iceberg/src/spec/values.rs:
##
@@ -3031,6 +3061,31 @@ mod tests {
check_avro_bytes_serde(bytes, Datum::string("iceberg"),
&PrimitiveType::String);
Xuanwo commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1873001766
##
crates/iceberg/src/spec/values.rs:
##
@@ -3031,6 +3061,31 @@ mod tests {
check_avro_bytes_serde(bytes, Datum::string("iceberg"),
&PrimitiveType::String);
Xuanwo commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1872977554
##
crates/iceberg/src/spec/values.rs:
##
@@ -449,7 +456,30 @@ impl Datum {
PrimitiveLiteral::String(val) => ByteBuf::from(val.as_bytes()),
P
Xuanwo commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1872778193
##
crates/iceberg/src/spec/values.rs:
##
@@ -3031,6 +3061,31 @@ mod tests {
check_avro_bytes_serde(bytes, Datum::string("iceberg"),
&PrimitiveType::String);
Fokko commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1872763818
##
crates/iceberg/src/spec/values.rs:
##
@@ -3031,6 +3061,31 @@ mod tests {
check_avro_bytes_serde(bytes, Datum::string("iceberg"),
&PrimitiveType::String);
liurenjie1024 commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1814592044
##
crates/iceberg/src/spec/values.rs:
##
@@ -449,7 +456,30 @@ impl Datum {
PrimitiveLiteral::String(val) => ByteBuf::from(val.as_bytes()),
Xuanwo commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1812068075
##
crates/iceberg/src/spec/values.rs:
##
@@ -449,7 +456,30 @@ impl Datum {
PrimitiveLiteral::String(val) => ByteBuf::from(val.as_bytes()),
P
sdd commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1811988261
##
crates/iceberg/src/spec/values.rs:
##
@@ -449,7 +456,30 @@ impl Datum {
PrimitiveLiteral::String(val) => ByteBuf::from(val.as_bytes()),
Prim
liurenjie1024 commented on code in PR #665:
URL: https://github.com/apache/iceberg-rust/pull/665#discussion_r1804486414
##
crates/iceberg/src/spec/values.rs:
##
@@ -3031,6 +3061,31 @@ mod tests {
check_avro_bytes_serde(bytes, Datum::string("iceberg"),
&PrimitiveType::S
14 matches
Mail list logo
