liurenjie1024 commented on PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2068035928
Thanks @marvinlanhenke for this pr!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
liurenjie1024 merged PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2066617634
cc @Fokko @Xuanwo @sdd PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
liurenjie1024 commented on PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2066513666
Let's wait a moment to see if others have comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
marvinlanhenke commented on PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2060905965
> For the 'missing table checks' - I'll file an Issue later, so we can track
this and implement in separate PRs.
#337
--
This is an automated message from the Apache Gi
marvinlanhenke commented on PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2060583038
@liurenjie1024
I think I fixed all of your suggestions - thanks again for the review.
For the 'missing table checks' - I'll file an Issue later, so we can track
this and i
marvinlanhenke commented on PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#issuecomment-2059160129
> Thanks for @marvinlanhenke for this great pr, it looks great! Sorry for
late reply, I have been busy lately.
@liurenjie1024
No worries, and thanks for the review.
marvinlanhenke commented on code in PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#discussion_r1567406955
##
crates/catalog/glue/src/catalog.rs:
##
@@ -310,31 +327,282 @@ impl Catalog for GlueCatalog {
Ok(table_list)
}
+/// Creates a new table
marvinlanhenke commented on code in PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#discussion_r1567403891
##
crates/catalog/glue/src/catalog.rs:
##
@@ -310,31 +327,282 @@ impl Catalog for GlueCatalog {
Ok(table_list)
}
+/// Creates a new table
marvinlanhenke commented on code in PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#discussion_r1567401176
##
crates/catalog/glue/src/utils.rs:
##
@@ -151,6 +205,65 @@ pub(crate) fn validate_namespace(namespace:
&NamespaceIdent) -> Result {
Ok(name)
}
+///
marvinlanhenke commented on code in PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#discussion_r1567401176
##
crates/catalog/glue/src/utils.rs:
##
@@ -151,6 +205,65 @@ pub(crate) fn validate_namespace(namespace:
&NamespaceIdent) -> Result {
Ok(name)
}
+///
liurenjie1024 commented on code in PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#discussion_r1565832014
##
crates/catalog/glue/src/utils.rs:
##
@@ -151,6 +205,65 @@ pub(crate) fn validate_namespace(namespace:
&NamespaceIdent) -> Result {
Ok(name)
}
+///
12 matches
Mail list logo
