marvinlanhenke commented on code in PR #314:
URL: https://github.com/apache/iceberg-rust/pull/314#discussion_r1567401176
##########
crates/catalog/glue/src/utils.rs:
##########
@@ -151,6 +205,65 @@ pub(crate) fn validate_namespace(namespace:
&NamespaceIdent) -> Result<String> {
Ok(name)
}
+/// Get default table location from `Namespace` properties
+pub(crate) fn get_default_table_location(
+ namespace: &Namespace,
+ table_name: impl AsRef<str>,
+ warehouse: impl AsRef<str>,
+) -> String {
+ let properties = namespace.properties();
+
+ let location = match properties.get(LOCATION) {
Review Comment:
Yes, you're right.
It seems that I missed `{database}.db` which would, in our case, equate to
the `db_name` (NamespaceIdent(Vec<String>)).
Should be easy to fix. Thanks for spotting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
