Fokko merged PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
kaushiksrini commented on PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681#issuecomment-2719104837
@Fokko, thanks - linted :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Fokko commented on PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681#issuecomment-2718949160
@kaushiksrini can you run `make lint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kaushiksrini commented on PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681#issuecomment-2699807325
thanks @Fokko! Made the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko commented on code in PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681#discussion_r1978898255
##
pyiceberg/avro/reader.py:
##
@@ -201,6 +201,15 @@ def skip(self, decoder: BinaryDecoder) -> None:
decoder.skip(16)
+class UnknownReader(Reader):
+
Fokko commented on code in PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681#discussion_r1961236785
##
pyiceberg/avro/encoder.py:
##
@@ -74,3 +75,7 @@ def write_uuid(self, uuid: UUID) -> None:
if len(uuid.bytes) != 16:
raise ValueError(f"Exp
