Fokko commented on code in PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681#discussion_r1961236785
##########
pyiceberg/avro/encoder.py:
##########
@@ -74,3 +75,7 @@ def write_uuid(self, uuid: UUID) -> None:
if len(uuid.bytes) != 16:
raise ValueError(f"Expected UUID to have 16 bytes, got:
len({uuid.bytes!r})")
return self.write(uuid.bytes)
+
+ def write_unknown(self, _: Any) -> None:
+ r"""Write an unknown type as a bytes as null value ('\0')."""
+ self.write_bytes(b"\0")
Review Comment:
_null_s are written as zero bytes in Avro:
https://avro.apache.org/docs/1.11.1/specification/#encodings
```suggestion
pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
