omkenge closed pull request #1234: feat: Add support for MMDD date formats
URL: https://github.com/apache/iceberg-python/pull/1234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
kevinjqliu commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424162564
@omkenge do you mind creating an issue first? We can have a discussion and
allow others to chime in before starting the PR
--
This is an automated message from the Apache Git
omkenge commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424141706
and also i have some suggestions on other parts also , i will create PR as
soon as possible
Plz also share your thoughts on that part also
Thank you for your time
--
This
omkenge commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424140033
Thank you for your feedback! I understand your concerns.
Ok then lets keep it simple and we can closed this PR with your final
comment ...
--
This is an automated message from
kevinjqliu commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424128401
Thanks for the context!
My opinion is that it's best not to add the `MMDD` format to the
pyiceberg library. Here are my reasoning.
- I think date parsing can be do
omkenge commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424103667
Hey @kevinjqliu sorry for the late reply ...
So talking about use cases ..
Many legacy systems and industries (e.g., government sectors) store dates in
compact MMDD format
kevinjqliu commented on PR #1234:
URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2420893458
hey @omkenge, thanks for the PR. What use case is this for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
omkenge opened a new pull request, #1234:
URL: https://github.com/apache/iceberg-python/pull/1234
### Support for Additional Date Format
Summary
This PR extends the date/time handling functions by adding support for one
additional formats:
- `MMDD` (e.g., `20241018`)
