kevinjqliu commented on PR #1234: URL: https://github.com/apache/iceberg-python/pull/1234#issuecomment-2424128401
Thanks for the context! My opinion is that it's best not to add the `YYYYMMDD` format to the pyiceberg library. Here are my reasoning. - I think date parsing can be done outside of the pyiceberg library. For example, we can transform date strings from `YYYYMMDD` to the currently supported ISO-8601 format (`YYYY-MM-DD`). - Supporting yet another date string format adds more complexity. If we support `YYYYMMDD`, why not also support `MMDDYYYY`? I think its best to only support ISO-8601 (`YYYY-MM-DD`) in the pyiceberg library and have other date strings transform to this format. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
