Fokko merged PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508885728
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub use term::
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508447324
##
crates/iceberg/src/spec/values.rs:
##
@@ -70,6 +79,571 @@ pub enum PrimitiveLiteral {
Decimal(i128),
}
+/// Literal associated with its type. The va
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508375681
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub us
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508372825
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub us
Fokko commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1507941201
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub use term::
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1506861883
##
crates/iceberg/src/expr/term.rs:
##
@@ -17,21 +17,89 @@
//! Term definition.
-use crate::spec::NestedFieldRef;
+use crate::expr::{BinaryExpression, Pre
ZENOTME commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1505918863
##
crates/iceberg/src/expr/term.rs:
##
@@ -17,21 +17,89 @@
//! Term definition.
-use crate::spec::NestedFieldRef;
+use crate::expr::{BinaryExpression, Predicate
liurenjie1024 commented on PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#issuecomment-1968719840
cc @sdd Any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1505434226
##
crates/iceberg/src/expr/term.rs:
##
@@ -17,21 +17,91 @@
//! Term definition.
-use crate::spec::NestedFieldRef;
+use crate::expr::{BinaryExpression, Pre
Xuanwo commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1505328726
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,126 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub use term:
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1505227423
##
crates/iceberg/src/expr/mod.rs:
##
@@ -64,3 +71,73 @@ impl Display for PredicateOperator {
}
}
}
+
+impl PredicateOperator {
+/// Check i
sdd commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1504701952
##
crates/iceberg/src/expr/mod.rs:
##
@@ -64,3 +71,73 @@ impl Display for PredicateOperator {
}
}
}
+
+impl PredicateOperator {
+/// Check if this ope
liurenjie1024 commented on PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#issuecomment-1965897689
Sorry for late reply, I have fixed comments, PTAL cc @Fokko @Xuanwo
@ZENOTME
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1503693670
##
crates/iceberg/src/spec/values.rs:
##
@@ -70,6 +79,571 @@ pub enum PrimitiveLiteral {
Decimal(i128),
}
+/// Literal associated with its type. The va
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1503606792
##
crates/iceberg/src/spec/values.rs:
##
@@ -70,6 +79,571 @@ pub enum PrimitiveLiteral {
Decimal(i128),
}
+/// Literal associated with its type. The va
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r150386
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -20,43 +20,89 @@
//! `a > 10` is a predicate expression, and it evaluates to `true` if `a` is
greater than `10
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1503555188
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,12 +18,15 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
pub use t
sdd commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1498011642
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,12 +18,15 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
pub use term::*;
m
TennyZhuang commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1474332462
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -20,43 +20,89 @@
//! `a > 10` is a predicate expression, and it evaluates to `true` if `a` is
greater than `10`,
Fokko commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1465970893
##
crates/iceberg/src/expr/term.rs:
##
@@ -17,21 +17,91 @@
//! Term definition.
-use crate::spec::NestedFieldRef;
+use crate::expr::{BinaryExpression, PredicateOp
liurenjie1024 commented on PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#issuecomment-1898009063
cc @Xuanwo @ZENOTME @Fokko PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
22 matches
Mail list logo
