Re: [PR] feat(puffin): Add Puffin crate and CompressionCodec [iceberg-rust]

2024-12-12 Thread via GitHub
fqaiser94 commented on code in PR #745: URL: https://github.com/apache/iceberg-rust/pull/745#discussion_r1883224527 ## crates/puffin/src/compression.rs: ## Review Comment: > I'm thinking how will we deal with PuffinReader/PuffindWriter, which will depend on FileIO?

Re: [PR] feat(puffin): Add Puffin crate and CompressionCodec [iceberg-rust]

2024-12-12 Thread via GitHub
fqaiser94 commented on code in PR #745: URL: https://github.com/apache/iceberg-rust/pull/745#discussion_r1883224527 ## crates/puffin/src/compression.rs: ## Review Comment: > I'm thinking how will we deal with PuffinReader/PuffindWriter, which will depend on FileIO?

Re: [PR] feat(puffin): Add Puffin crate and CompressionCodec [iceberg-rust]

2024-12-12 Thread via GitHub
liurenjie1024 commented on code in PR #745: URL: https://github.com/apache/iceberg-rust/pull/745#discussion_r1881794442 ## crates/puffin/src/compression.rs: ## Review Comment: Do we really need to put this outside of iceberg crate? I'm thinking how will we deal with `Puffi

Re: [PR] feat(puffin): Add Puffin crate and CompressionCodec [iceberg-rust]

2024-12-06 Thread via GitHub
Xuanwo merged PR #745: URL: https://github.com/apache/iceberg-rust/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

[PR] feat(puffin): Add Puffin crate and CompressionCodec [iceberg-rust]

2024-11-30 Thread via GitHub
fqaiser94 opened a new pull request, #745: URL: https://github.com/apache/iceberg-rust/pull/745 Changes summary: - Add Puffin crate - Add `CompressionCodec` For more information/context, see https://github.com/apache/iceberg-rust/issues/744 -- This is an automated message fr