fqaiser94 commented on code in PR #745: URL: https://github.com/apache/iceberg-rust/pull/745#discussion_r1883224527
########## crates/puffin/src/compression.rs: ########## Review Comment: > I'm thinking how will we deal with PuffinReader/PuffindWriter, which will depend on FileIO? I don't understand why this would cause issues since `FileIO` is a publicly exposed interface? > Do we really need to put this outside of iceberg crate? That said, I think you're right. I don't see any compelling reasons to separate this functionality into a separate crate outside of the iceberg crate. I didn't consider this option; I just forgot 😅 Here's a quick follow-up PR to move this functionality inside of the existing iceberg crate: https://github.com/apache/iceberg-rust/pull/789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
