Fokko commented on PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#issuecomment-2591769403
Thanks @zeroshade 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Fokko merged PR #245:
URL: https://github.com/apache/iceberg-go/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
Fokko commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1916018700
##
table/metadata.go:
##
@@ -1029,3 +1030,76 @@ func (m *metadataV2) UnmarshalJSON(b []byte) error {
m.preValidate()
return m.validate()
}
+
+const Defa
zeroshade commented on PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#issuecomment-2588263730
@Fokko any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
zeroshade commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1913825350
##
catalog/rest.go:
##
@@ -663,18 +631,40 @@ func splitIdentForPath(ident table.Identifier) (string,
string, error) {
return strings.Join(NamespaceFromIdent
kevinjqliu commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1913823798
##
catalog/catalog.go:
##
@@ -195,3 +200,36 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Ident
zeroshade commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1913822331
##
catalog/catalog.go:
##
@@ -195,3 +200,36 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Identi
kevinjqliu commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1908136750
##
catalog/catalog.go:
##
@@ -195,3 +200,36 @@ func TableNameFromIdent(ident table.Identifier) string {
func NamespaceFromIdent(ident table.Identifier) table.Ident
zeroshade commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1911296722
##
table/metadata_internal_test.go:
##
@@ -491,3 +491,118 @@ func TestV1WriteMetadataToV2(t *testing.T) {
assert.NotContains(t, rawData, "schema")
as
Fokko commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1911289679
##
table/metadata_internal_test.go:
##
@@ -491,3 +491,118 @@ func TestV1WriteMetadataToV2(t *testing.T) {
assert.NotContains(t, rawData, "schema")
assert
zeroshade opened a new pull request, #245:
URL: https://github.com/apache/iceberg-go/pull/245
Adding a CreateTable function to the `Catalog` interface, standardizing the
implementation that was initially created by #146 so that it isn't specific to
the REST catalog and can be implemented by
11 matches
Mail list logo
