Fokko commented on code in PR #245:
URL: https://github.com/apache/iceberg-go/pull/245#discussion_r1911289679
##########
table/metadata_internal_test.go:
##########
@@ -491,3 +491,118 @@ func TestV1WriteMetadataToV2(t *testing.T) {
assert.NotContains(t, rawData, "schema")
assert.NotContains(t, rawData, "partition-spec")
}
+
+func TestNewMetadataWithExplicitV1Format(t *testing.T) {
Review Comment:
It would be nice to have a nested struct in the test to validate the
pre-order traversal :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
