Fokko commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1911896187
Fully Agree! Thanks @Xuanwo for working on this! And @jbonofre and
@liurenjie1024 for the reviews 🙏
--
This is an automated message from the Apache Git Service.
To respond to the messa
Fokko merged PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
jbonofre commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1911787495
I agree, +1 to merge this PR 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Xuanwo commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1911456020
Hi, @Fokko maybe we can merge this PR and move forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jbonofre commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1909686378
@Xuanwo Thanks for your feedback.
I missed `skywalking-eyes`. I will double check in the src distribution.
For the `NOTICE` file, I would at least list the different licen
Xuanwo commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1909680183
Hi, @jbonofre, thanks a lot for the reviewing!
> 1. The distribution should limit the file without ASF header. We can add
RAT to check that (in `dev` folder for instance). No need
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1465949315
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache requ
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462719672
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
liurenjie1024 commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462861172
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apa
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462721064
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462723178
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462722701
##
website/src/download.md:
##
Review Comment:
> Then how about adding one section in `install.md` with title `Build from
source`? I think they are just one way
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462721064
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1462719672
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1899954667
> cc @Xuanwo Any updates?
Sorry for busy in other projects, I will revist this PR later today.
--
This is an automated message from the Apache Git Service.
To respond to the mes
liurenjie1024 commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1899908129
cc @Xuanwo Any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
liurenjie1024 commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442622182
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apa
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442602143
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache requ
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442600155
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache requ
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442599810
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache requ
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442598860
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache requ
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442599426
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache requ
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442598483
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache requ
Fokko commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442596925
##
website/src/reference/setup_gpg.md:
##
@@ -0,0 +1,161 @@
+
+
+# Setup GPG key
+
+> This section is a brief from the [Cryptography with
OpenPGP](https://infra.apach
liurenjie1024 commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442520271
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apa
liurenjie1024 commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442520171
##
website/src/download.md:
##
Review Comment:
> ASF release policy requires that users have the ability to download and
build from source.
Then h
liurenjie1024 commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442519521
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apa
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442474047
##
website/src/download.md:
##
Review Comment:
> I think maybe we don't need this
ASF release policy requires that users have the ability to download and
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442473747
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442473406
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442473048
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442472860
##
website/src/release.md:
##
@@ -0,0 +1,383 @@
+
+
+This document mainly introduces how the release manager releases a new version
in accordance with the Apache req
Xuanwo commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442472242
##
crates/catalog/hms/DEPENDENCIES.rust.tsv:
##
Review Comment:
The ASF release requires users to have a complete list of our dependencies
to ensure compliance
liurenjie1024 commented on code in PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442448609
##
crates/catalog/hms/DEPENDENCIES.rust.tsv:
##
Review Comment:
What are these tsv files used for?
##
website/src/release.md:
##
@@ -0,
Xuanwo commented on PR #147:
URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1878030924
Hi @Fokko, if you think this PR is too large, I can split it up. For
instance, I could add the scripts in separate PRs.
--
This is an automated message from the Apache Git Service.
To
Xuanwo opened a new pull request, #147:
URL: https://github.com/apache/iceberg-rust/pull/147
Part of https://github.com/apache/iceberg-rust/issues/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
36 matches
Mail list logo
