Xuanwo commented on PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1909680183
Hi, @jbonofre, thanks a lot for the reviewing! > 1. The distribution should limit the file without ASF header. We can add RAT to check that (in `dev` folder for instance). No need to always execute it, but at least when releasing and creating the source distribution. As reminder, ASF requires the src distribution to be available on `dist.apache.org`., this is the minimum artifact that should be distributed (and user can build from there). We are using [`skywalking-eyes`](https://github.com/apache/skywalking-eyes) to check the ASF headers. And this has been check in all PRs. > 2. `NOTICE` file looks incomplete to me. It should list all dependencies included (e.g. distributed) and used (for instance to build/distribute). It's also a good practice to list all a summary of all different licenses used. Regarding `DEPENDENCIES.rust.tsv` files, `NOTICE` looks pretty short. I can help on this :) The `iceberg-rust` library is a pure Rust implementation that doesn't bundle any dependencies in our release. Should we still include dependencies in the NOTICE file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
