kevinjqliu commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2628599894
@sikehish this PR looks good overall, with just a few minor changes. Would
you like to work through these together and take it over the finish line? :)
--
This is an automate
kevinjqliu commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2442136343
Thanks for the review Fokko. +1 to adding a section to call out what is
supported and unsupported.
I believe these 3 are currently the unsupported properties
https://git
Fokko commented on code in PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#discussion_r1819195993
##
mkdocs/docs/configuration.md:
##
@@ -30,15 +30,23 @@ Iceberg tables support table properties to configure table
behavior.
### Write options
-| Key
kevinjqliu commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2424118781
Hi @mths1, Thanks for the feedback. You're right,
`write.target-file-size-bytes` does not represent the resulting file's size on
disk. It's based on the size of the in-memory ar
mths1 commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2422796878
Hi all
I was trying 'target-file-size-bytes' lately, and to my understanding in
the pyiceberg version we were using, it somehow violates the principle of least
surprise. As f
sikehish commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2420292280
>
https://github.com/apache/iceberg-python/actions/runs/11389073844/job/31690659534?pr=1232
Yup, linting is in place now. Thanks for the reminder!
--
This is an automated
kevinjqliu commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2420244677
https://github.com/apache/iceberg-python/actions/runs/11389073844/job/31690659534?pr=1232
--
This is an automated message from the Apache Git Service.
To respond to the messag
sikehish commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2420232911
> @sikehish can you fix the CI lint issue? `make lint` should work
>
> There are other "good first issue"s, please take a look
https://github.com/apache/iceberg-python/issue
kevinjqliu commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2420218362
@sikehish can you fix the CI lint issue? `make lint` should work
There are other "good first issue"s, please take a look
https://github.com/apache/iceberg-python/issues?q=
sikehish commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2420140541
> LGTM! Thanks for working on this
Thank you for the oppurtunity! Do let me know if you would want me to work
on any other issue :))
--
This is an automated message from
sikehish commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2420009547
@kevinjqliu
Hi, I've made the changes. Do let me know if any other changes are to be
made.
--
This is an automated message from the Apache Git Service.
To respond to the mes
sikehish commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2420008561
> Also curious if you have suggestion to prevent documentation drift in the
future
I believe we could utilize automated documentation generation tools or
enforce strict doc
sikehish commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2419979292
> I noticed these 3 options are missing
>
>
https://github.com/apache/iceberg-python/blob/7cf0c225c3cdb32ac5e390de06b7b0e4fe7de92e/pyiceberg/table/__init__.py#L197-L204
kevinjqliu commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2419893328
Also curious if you have suggestion to prevent documentation drift in the
future
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kevinjqliu commented on PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#issuecomment-2419887779
I noticed these 3 options are missing
https://github.com/apache/iceberg-python/blob/7cf0c225c3cdb32ac5e390de06b7b0e4fe7de92e/pyiceberg/table/__init__.py#L197-L204
--
This
kevinjqliu commented on code in PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#discussion_r1805007235
##
mkdocs/docs/configuration.md:
##
@@ -30,16 +30,25 @@ Iceberg tables support table properties to configure table
behavior.
### Write options
-| Key
sikehish opened a new pull request, #1232:
URL: https://github.com/apache/iceberg-python/pull/1232
This PR is for #1231.
### **Changes**
- Added missing table properties to the `configuration.md` file, including:
- `write.target-file-size-bytes`
- `write.parquet.row-grou
17 matches
Mail list logo
