kevinjqliu commented on code in PR #1232:
URL: https://github.com/apache/iceberg-python/pull/1232#discussion_r1805007235
##########
mkdocs/docs/configuration.md:
##########
@@ -30,16 +30,25 @@ Iceberg tables support table properties to configure table
behavior.
### Write options
-| Key | Options |
Default | Description
|
-| -------------------------------------- | --------------------------------- |
------- |
-------------------------------------------------------------------------------------------
|
-| `write.parquet.compression-codec` | `{uncompressed,zstd,gzip,snappy}` |
zstd | Sets the Parquet compression coddec.
|
-| `write.parquet.compression-level` | Integer |
null | Parquet compression level for the codec. If not set, it is up to
PyIceberg |
-| `write.parquet.row-group-limit` | Number of rows |
1048576 | The upper bound of the number of entries within a single row group
|
-| `write.parquet.page-size-bytes` | Size in bytes |
1MB | Set a target threshold for the approximate encoded size of data pages
within a column chunk |
-| `write.parquet.page-row-limit` | Number of rows |
20000 | Set a target threshold for the approximate encoded size of data pages
within a column chunk |
-| `write.parquet.dict-size-bytes` | Size in bytes |
2MB | Set the dictionary page size limit per row group
|
-| `write.metadata.previous-versions-max` | Integer |
100 | The max number of previous version metadata files to keep before
deleting after commit. |
-
+| Key | Options
| Default | Description
|
+| -------------------------------------- |
-------------------------------------- | --------------- |
-------------------------------------------------------------------------------------------
|
+| `write.parquet.compression-codec` | `{uncompressed,zstd,gzip,snappy}`
| zstd | Sets the Parquet compression codec.
|
+| `write.parquet.compression-level` | Integer
| null | Parquet compression level for the codec. If not set, it
is up to PyIceberg. |
+| `write.parquet.row-group-limit` | Number of rows
| 1,048,576 | The upper bound of the number of entries within a single
row group. |
+| `write.parquet.row-group-size-bytes` | Size in bytes
| 128 MB | The maximum size (in bytes) of each Parquet row group.
|
+| `write.parquet.page-size-bytes` | Size in bytes
| 1 MB | Target threshold for the approximate encoded size of
data pages within a column chunk. |
+| `write.parquet.page-row-limit` | Number of rows
| 20,000 | Target threshold for the number of rows within a data
page inside a column chunk. |
+| `write.parquet.dict-size-bytes` | Size in bytes
| 2 MB | The dictionary page size limit per row group.
|
+| `write.parquet.bloom-filter-max-bytes` | Size in bytes
| 1 MB | The maximum size (in bytes) of the Bloom filter for
Parquet files. |
+| `write.parquet.bloom-filter-enabled.column` | Column names
| N/A | Enable Bloom filters for specific columns by prefixing
the column name. |
+| `write.target-file-size-bytes` | Size in bytes
| 512 MB | Target size (in bytes) for each output data file.
|
+| `write.metadata.metrics.default` | `{none, full, truncate(N)}`
| `truncate(16)` | Default metrics mode to use when writing files.
|
+| `write.metadata.metrics.column` | Column names and modes
| N/A | Per-column metrics configuration.
|
+| `write.summary.partition-limit` | Integer
| 0 | The limit on the number of partition summaries written
with each commit. |
+| `write.delete.mode` | `{copy-on-write, merge-on-read}`
| `copy-on-write` | Configures the delete mode (either Copy-on-Write or
Merge-on-Read). |
+| `schema.name-mapping.default` | Name mapping strategy
| N/A | Default name mapping for schema evolution.
|
+| `format-version` | `{1, 2}`
| 2 | The version of the Iceberg table format to use.
|
Review Comment:
nit: i think these 2 are not "write options" but rather "table options"
##########
mkdocs/docs/configuration.md:
##########
@@ -30,16 +30,25 @@ Iceberg tables support table properties to configure table
behavior.
### Write options
-| Key | Options |
Default | Description
|
-| -------------------------------------- | --------------------------------- |
------- |
-------------------------------------------------------------------------------------------
|
-| `write.parquet.compression-codec` | `{uncompressed,zstd,gzip,snappy}` |
zstd | Sets the Parquet compression coddec.
|
-| `write.parquet.compression-level` | Integer |
null | Parquet compression level for the codec. If not set, it is up to
PyIceberg |
-| `write.parquet.row-group-limit` | Number of rows |
1048576 | The upper bound of the number of entries within a single row group
|
-| `write.parquet.page-size-bytes` | Size in bytes |
1MB | Set a target threshold for the approximate encoded size of data pages
within a column chunk |
-| `write.parquet.page-row-limit` | Number of rows |
20000 | Set a target threshold for the approximate encoded size of data pages
within a column chunk |
-| `write.parquet.dict-size-bytes` | Size in bytes |
2MB | Set the dictionary page size limit per row group
|
-| `write.metadata.previous-versions-max` | Integer |
100 | The max number of previous version metadata files to keep before
deleting after commit. |
-
+| Key | Options
| Default | Description
|
+| -------------------------------------- |
-------------------------------------- | --------------- |
-------------------------------------------------------------------------------------------
|
+| `write.parquet.compression-codec` | `{uncompressed,zstd,gzip,snappy}`
| zstd | Sets the Parquet compression codec.
|
+| `write.parquet.compression-level` | Integer
| null | Parquet compression level for the codec. If not set, it
is up to PyIceberg. |
+| `write.parquet.row-group-limit` | Number of rows
| 1,048,576 | The upper bound of the number of entries within a single
row group. |
+| `write.parquet.row-group-size-bytes` | Size in bytes
| 128 MB | The maximum size (in bytes) of each Parquet row group.
|
+| `write.parquet.page-size-bytes` | Size in bytes
| 1 MB | Target threshold for the approximate encoded size of
data pages within a column chunk. |
+| `write.parquet.page-row-limit` | Number of rows
| 20,000 | Target threshold for the number of rows within a data
page inside a column chunk. |
+| `write.parquet.dict-size-bytes` | Size in bytes
| 2 MB | The dictionary page size limit per row group.
|
+| `write.parquet.bloom-filter-max-bytes` | Size in bytes
| 1 MB | The maximum size (in bytes) of the Bloom filter for
Parquet files. |
+| `write.parquet.bloom-filter-enabled.column` | Column names
| N/A | Enable Bloom filters for specific columns by prefixing
the column name. |
+| `write.target-file-size-bytes` | Size in bytes
| 512 MB | Target size (in bytes) for each output data file.
|
+| `write.metadata.metrics.default` | `{none, full, truncate(N)}`
| `truncate(16)` | Default metrics mode to use when writing files.
|
+| `write.metadata.metrics.column` | Column names and modes
| N/A | Per-column metrics configuration.
|
+| `write.summary.partition-limit` | Integer
| 0 | The limit on the number of partition summaries written
with each commit. |
+| `write.delete.mode` | `{copy-on-write, merge-on-read}`
| `copy-on-write` | Configures the delete mode (either Copy-on-Write or
Merge-on-Read). |
+| `schema.name-mapping.default` | Name mapping strategy
| N/A | Default name mapping for schema evolution.
|
+| `format-version` | `{1, 2}`
| 2 | The version of the Iceberg table format to use.
|
+| `write.metadata.previous-versions-max` | Integer
| 100 | Maximum number of previous version metadata files to
keep before deletion after commit. |
Review Comment:
nit: group this with the other `write.metadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
