Re: [PR] backport c++23 std::expected [iceberg-cpp]

Fokko commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2684638023 Thanks @zhjwpku for adding this, and the `LICENSE` looks good to me. I don't think we need to update the `NOTICE`, but we can revisit that at the release when we have to do a full pass anyw

Re: [PR] backport c++23 std::expected [iceberg-cpp]

Fokko merged PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2667391713 An Apache member corrected this in arrow-java by making sure vendored files had their original license header: https://github.com/apache/arrow-java/pull/550 -- This is an automated mes

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2667321536 > I'm surprised by the license header. Shouldn't we use the Apache license there and record the provenance elsewhere? Yes, that was the initial version. I adopted the ASF License an

Re: [PR] backport c++23 std::expected [iceberg-cpp]

pitrou commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2664936223 I'm surprised by the license header. Shouldn't we use the Apache license there and record the provenance elsewhere? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] backport c++23 std::expected [iceberg-cpp]

wgtmac commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2664807118 @pitrou @raulcd Do you have any comment on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2639011661 @Fokko @Xuanwo I'd appreciate it if you could review this backport of `std::expected`. While we haven't yet decided whether to use `expected` over `exception`, having this backport ready

Re: [PR] backport c++23 std::expected [iceberg-cpp]

wgtmac commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2636892096 > That may lead to ABI issues. For example if iceberg-cpp is compiled using a C++20 compiler, and then an application links to it with C++23 enabled. Or the reverse. Make sense. Tha

Re: [PR] backport c++23 std::expected [iceberg-cpp]

pitrou commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2636748429 > Is it possible to check the macro [__cpp_lib_expected](https://en.cppreference.com/w/cpp/feature_test#cpp_lib_expected) and directly use `std::expected` if available? That may lea

Re: [PR] backport c++23 std::expected [iceberg-cpp]

wgtmac commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2635820910 Is it possible to check the macro [__cpp_lib_expected](https://en.cppreference.com/w/cpp/feature_test#cpp_lib_expected) and directly use `std::expected` if available? -- This is an auto

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2633426269 > LGTM. IMO let's get moving on this. > > BTW, we could consider writing a custom check to just enforce `[[nodiscard]]` on functions returning `expected`? https://clang.llvm.org/ex

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1940862373 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1940318960 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1939533979 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1939509347 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1939509347 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1939502825 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1939495804 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1939415372 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1931472832 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

wgtmac commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1931466108 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

wgtmac commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930469633 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1931355812 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

wgtmac commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930469633 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

wgtmac commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930469633 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930454500 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930450870 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930406377 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930259449 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930259835 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

raulcd commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930231246 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

raulcd commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930227269 ## src/iceberg/expected.h: ## @@ -0,0 +1,2333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1930185280 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1929975364 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

Re: [PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1929955037 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] backport c++23 std::expected [iceberg-cpp]

lidavidm commented on code in PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#discussion_r1929899791 ## src/iceberg/expected.h: ## @@ -0,0 +1,2332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

[PR] backport c++23 std::expected [iceberg-cpp]

zhjwpku opened a new pull request, #40: URL: https://github.com/apache/iceberg-cpp/pull/40 After studied [0], [1] and [2], I'm inclined to backport [0] to iceberg-cpp, the main reason is that [0] has exactly the same APIs as std::expected, [1] provide some extra member functions like `map`