zhjwpku commented on PR #40: URL: https://github.com/apache/iceberg-cpp/pull/40#issuecomment-2633426269
> LGTM. IMO let's get moving on this. > > BTW, we could consider writing a custom check to just enforce `[[nodiscard]]` on functions returning `expected`? https://clang.llvm.org/extra/clang-tidy/Contributing.html Reasonable, will file an issue once this PR got merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
