Re: [PR] allow string transforms in add_field() [iceberg-python]

2025-04-09 Thread via GitHub
Federico-Vichachi closed pull request #1883: allow string transforms in add_field() URL: https://github.com/apache/iceberg-python/pull/1883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] allow string transforms in add_field() [iceberg-python]

2025-04-07 Thread via GitHub
Federico-Vichachi commented on PR #1883: URL: https://github.com/apache/iceberg-python/pull/1883#issuecomment-2784186020 Hi @Fokko, I appreciate your corrections and will include them. Regarding the test, I was trying to run the following one but had problems installing the project's depend

Re: [PR] allow string transforms in add_field() [iceberg-python]

2025-04-05 Thread via GitHub
Fokko commented on code in PR #1883: URL: https://github.com/apache/iceberg-python/pull/1883#discussion_r2029929421 ## pyiceberg/table/update/spec.py: ## @@ -128,6 +133,7 @@ def add_field( self._adds.append(new_field) return self + def add_identity(self,

[PR] allow string transforms in add_field() [iceberg-python]

2025-04-04 Thread via GitHub
Federico-Vichachi opened a new pull request, #1883: URL: https://github.com/apache/iceberg-python/pull/1883 Closes #1011 # Rationale for this change This change allows the `add_field` method to accept `str` values as transform inputs, in addition to `Transform` instances. This impr