Fokko commented on code in PR #1883:
URL: https://github.com/apache/iceberg-python/pull/1883#discussion_r2029929421
##########
pyiceberg/table/update/spec.py:
##########
@@ -128,6 +133,7 @@ def add_field(
self._adds.append(new_field)
return self
+
def add_identity(self, source_column_name: str) -> UpdateSpec:
Review Comment:
I think we need to revert this to make the linter happy:
```suggestion
def add_identity(self, source_column_name: str) -> UpdateSpec:
```
##########
pyiceberg/table/update/spec.py:
##########
@@ -85,12 +86,16 @@ def __init__(self, transaction: Transaction,
case_sensitive: bool = True) -> Non
def add_field(
self,
source_column_name: str,
- transform: Transform[Any, Any],
+ transform: Union[str, Transform[Any, Any]], # Aceptamos strings o
Transform
Review Comment:
😉
```suggestion
transform: Union[str, Transform[Any, Any]], # We accept strings or
Transform
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
