Re: [PR] add support for glue.id [iceberg-python]

HonahX merged PR #490: URL: https://github.com/apache/iceberg-python/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on PR #490: URL: https://github.com/apache/iceberg-python/pull/490#issuecomment-1977246026 @HonahX appreciate the review! Pushed a new commit with your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1511608985 ## pyiceberg/catalog/glue.py: ## @@ -93,6 +93,13 @@ if TYPE_CHECKING: import pyarrow as pa + +# There is a unique Glue metastore in each AWS account and eac

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1511604893 ## pyiceberg/catalog/glue.py: ## @@ -266,6 +289,10 @@ def __init__(self, name: str, **properties: Any): ) self.glue: GlueClient = session.client("

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1511604071 ## pyiceberg/catalog/glue.py: ## @@ -252,6 +259,22 @@ def _construct_database_input(database_name: str, properties: Properties) -> Dat return database_input

Re: [PR] add support for glue.id [iceberg-python]

HonahX commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1510041483 ## pyiceberg/catalog/glue.py: ## @@ -252,6 +259,22 @@ def _construct_database_input(database_name: str, properties: Properties) -> Dat return database_input

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1509829128 ## pyiceberg/catalog/glue.py: ## @@ -252,6 +259,22 @@ def _construct_database_input(database_name: str, properties: Properties) -> Dat return database_input

Re: [PR] add support for glue.id [iceberg-python]

Fokko commented on PR #490: URL: https://github.com/apache/iceberg-python/pull/490#issuecomment-1974732024 @HonahX since you're more familiar with Glue, would you be able to do this review? :) -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1509830589 ## pyiceberg/catalog/glue.py: ## @@ -93,6 +93,13 @@ if TYPE_CHECKING: import pyarrow as pa + +# There is a unique Glue metastore in each AWS account and eac

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1509829128 ## pyiceberg/catalog/glue.py: ## @@ -252,6 +259,22 @@ def _construct_database_input(database_name: str, properties: Properties) -> Dat return database_input

Re: [PR] add support for glue.id [iceberg-python]

jrouly commented on code in PR #490: URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1509828986 ## pyiceberg/catalog/glue.py: ## @@ -252,6 +259,22 @@ def _construct_database_input(database_name: str, properties: Properties) -> Dat return database_input

[PR] add support for glue.id [iceberg-python]

jrouly opened a new pull request, #490: URL: https://github.com/apache/iceberg-python/pull/490 The [upstream Iceberg documentation](https://iceberg.apache.org/docs/1.4.0/aws/#glue-catalog-id) details `glue.id` as a parameter which can be used to set the AWS Glue Catalog ID (AWS Account ID)