Re: [PR] add assertions in TestRowDelta [iceberg]

2024-11-23 Thread via GitHub
sullis closed pull request #11594: add assertions in TestRowDelta URL: https://github.com/apache/iceberg/pull/11594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] add assertions in TestRowDelta [iceberg]

2024-11-23 Thread via GitHub
sullis commented on code in PR #11594: URL: https://github.com/apache/iceberg/pull/11594#discussion_r1855223900 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -74,6 +74,9 @@ public void addOnlyDeleteFilesProducesDeleteOperation() { assertThat(snap.sequenc

Re: [PR] add assertions in TestRowDelta [iceberg]

2024-11-19 Thread via GitHub
nastra commented on code in PR #11594: URL: https://github.com/apache/iceberg/pull/11594#discussion_r1849698894 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -74,6 +74,9 @@ public void addOnlyDeleteFilesProducesDeleteOperation() { assertThat(snap.sequenc