nastra commented on code in PR #11594:
URL: https://github.com/apache/iceberg/pull/11594#discussion_r1849698894


##########
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##########
@@ -74,6 +74,9 @@ public void addOnlyDeleteFilesProducesDeleteOperation() {
     assertThat(snap.sequenceNumber()).isEqualTo(1);
     assertThat(snap.operation()).isEqualTo(DataOperations.DELETE);
     assertThat(snap.deleteManifests(table.io())).hasSize(1);
+    assertThat(snap.dataManifests(table.io())).hasSize(0);

Review Comment:
   is this necessary here? the main purpose of the test is to verify that it 
produces `DataOperations.DELETE` when adding deletes only



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to