Re: [PR] Write small decimals as INTs [iceberg-python]

2025-05-11 Thread via GitHub
kevinjqliu merged PR #1983: URL: https://github.com/apache/iceberg-python/pull/1983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Write small decimals as INTs [iceberg-python]

2025-05-10 Thread via GitHub
Fokko commented on PR #1983: URL: https://github.com/apache/iceberg-python/pull/1983#issuecomment-2869148157 @kevinjqliu Good call, looking at the code, it seems like it will automatically map it to INT32/INT64: https://github.com/apache/arrow/blob/598938711a8376cbfdceaf5c77ab0fd5057e6c02/c

Re: [PR] Write small decimals as INTs [iceberg-python]

2025-05-10 Thread via GitHub
Fokko commented on code in PR #1983: URL: https://github.com/apache/iceberg-python/pull/1983#discussion_r2083285244 ## pyiceberg/io/pyarrow.py: ## @@ -636,7 +636,13 @@ def visit_fixed(self, fixed_type: FixedType) -> pa.DataType: return pa.binary(len(fixed_type))

Re: [PR] Write small decimals as INTs [iceberg-python]

2025-05-09 Thread via GitHub
kevinjqliu commented on PR #1983: URL: https://github.com/apache/iceberg-python/pull/1983#issuecomment-2867050506 > FAILED tests/io/test_pyarrow_stats.py::test_metrics_primitive_types - pyarrow.lib.ArrowNotImplementedError: Unhandled type for Arrow to Parquet schema conversion: decimal32(5,

Re: [PR] Write small decimals as INTs [iceberg-python]

2025-05-09 Thread via GitHub
kevinjqliu commented on code in PR #1983: URL: https://github.com/apache/iceberg-python/pull/1983#discussion_r2081953874 ## pyiceberg/io/pyarrow.py: ## @@ -636,7 +636,13 @@ def visit_fixed(self, fixed_type: FixedType) -> pa.DataType: return pa.binary(len(fixed_type))

Re: [PR] Write small decimals as INTs [iceberg-python]

2025-05-08 Thread via GitHub
Fokko commented on PR #1983: URL: https://github.com/apache/iceberg-python/pull/1983#issuecomment-2864053383 CI failing due to the release of snowballstemmer: https://pypi.org/project/snowballstemmer/#history -- This is an automated message from the Apache Git Service. To respond to the m

[PR] Write small decimals as INTs [iceberg-python]

2025-05-08 Thread via GitHub
Fokko opened a new pull request, #1983: URL: https://github.com/apache/iceberg-python/pull/1983 # Rationale for this change Resolves https://github.com/apache/iceberg-python/issues/1979 # Are these changes tested? # Are there any user-facing changes? -- Thi