Fokko merged PR #441:
URL: https://github.com/apache/iceberg-python/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #441:
URL: https://github.com/apache/iceberg-python/pull/441#discussion_r1496576875
##
tests/table/test_name_mapping.py:
##
@@ -238,3 +245,67 @@ def test_mapping_lookup_by_name(table_name_mapping_nested:
NameMapping) -> None:
with pytest.rai
syun64 commented on code in PR #441:
URL: https://github.com/apache/iceberg-python/pull/441#discussion_r1495092898
##
pyiceberg/table/name_mapping.py:
##
@@ -45,6 +45,18 @@ class MappedField(IcebergBaseModel):
def convert_null_to_empty_List(cls, v: Any) -> Any:
ret
Fokko commented on code in PR #441:
URL: https://github.com/apache/iceberg-python/pull/441#discussion_r1493898782
##
pyiceberg/table/__init__.py:
##
@@ -1932,6 +1928,13 @@ def commit(self) -> None:
else:
updates =
(SetCurrentSchemaUpdate(schema_id=
syun64 opened a new pull request, #441:
URL: https://github.com/apache/iceberg-python/pull/441
Similar to the [Java
implementation](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SchemaUpdate.java#L464),
we should update the existing name_mapping on update
