Fokko commented on code in PR #441:
URL: https://github.com/apache/iceberg-python/pull/441#discussion_r1496576875
##########
tests/table/test_name_mapping.py:
##########
@@ -238,3 +245,67 @@ def test_mapping_lookup_by_name(table_name_mapping_nested:
NameMapping) -> None:
with pytest.raises(ValueError, match="Could not find field with name:
boom"):
table_name_mapping_nested.find("boom")
+
+
+def test_invalid_mapped_field() -> None:
+ with pytest.raises(ValueError):
+ MappedField(field_id=1, names=[])
+
+
+def test_update_mapping_no_updates_or_adds(table_name_mapping_nested:
NameMapping) -> None:
+ assert update_mapping(table_name_mapping_nested, {}, {}) ==
table_name_mapping_nested
+
+
+def test_update_mapping(table_name_mapping_nested: NameMapping) -> None:
+ updates = {1: NestedField(1, "foo_update", StringType(), True)}
+ adds = {
+ -1: [NestedField(18, "add_18", StringType(), True)],
+ 15: [NestedField(19, "name", StringType(), True), NestedField(20,
"add_20", StringType(), True)],
+ }
Review Comment:
Ah, I see. That makes sense to me. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
