Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 merged PR #587: URL: https://github.com/apache/iceberg-rust/pull/587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1858099484 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1856147630 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1851960088 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850728077 ## crates/iceberg/src/spec/schema.rs: ## @@ -376,6 +375,24 @@ impl Schema { pub fn accessor_by_field_id(&self, field_id: i32) -> Option> { self.field_

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850724460 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2097 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850730060 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850737095 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850726133 ## crates/iceberg/src/catalog/mod.rs: ## @@ -912,14 +950,14 @@ mod tests { #[test] fn test_check_last_assigned_partition_id() { let metadata = met

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850729114 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850724196 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850678695 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2063 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850677446 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1848526215 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1848261434 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1846505256 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1846578408 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1846508704 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1846496245 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2063 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1845199857 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2480672053 > @liurenjie1024 for `set_branch_snapshot` I was missing an easy way to determine the type of a ref. I introduced an enum `ReferenceType`, but if you don't like that, I can also just i

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844949615 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2097 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844668631 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2480146878 @liurenjie1024 for `set_branch_snapshot` I was missing an easy way to determine the type of a ref. I introduced an enum `ReferenceType`, but if you don't like that, I can also just

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844670884 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844669519 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844668631 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844602893 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2063 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844602893 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2063 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1844601246 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843960491 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843798302 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843722934 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2097 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843792590 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1841689100 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843538624 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843391072 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843474749 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843470487 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843470080 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843459923 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843459923 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843426365 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843439530 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843439530 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843426365 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843384458 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2063 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843428792 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843407355 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1843388062 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2063 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1842164987 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1842113157 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1842123013 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1842119068 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2070 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1842095090 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1842093914 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1841954312 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1840676594 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1840657040 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1840628244 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836563989 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836563989 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836555246 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836550038 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

Fokko commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836548727 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836152900 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836152059 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836152059 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1836147269 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834692436 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834836340 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834831646 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834825302 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834821906 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834805599 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834703801 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834700957 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834696233 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on code in PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1834692436 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -0,0 +1,2074 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2461442365 @Xuanwo, @liurenjie1024 this PR is ready for another round of review. It's now rebased on the 6 PRs we merged during the last months. The core logic is ~1100 lines of code, including q

Re: [PR] TableMetadataBuilder [iceberg-rust]

Xuanwo commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2338031867 I have reviewed most PRs that I am confident can be merged. The only one left is https://github.com/apache/iceberg-rust/pull/615, for which I need more input. -- This is an automated

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2337769487 @liurenjie1024 thanks for the Feedback! > > My first point of the opening statement: Do we re-write our SortOrder and add the schema to PartitionSpec so that we can match on name

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2337063983 > After we answered those questions, and we still think splitting makes sense, I can try to find time to build stacked-PRs. Maybe just splitting normalization / validation in tab

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2336618257 @liurenjie1024 I tried to cut a few things out - but not along the lines of `TalbeUpdate`. I hope that's OK? 1. https://github.com/apache/iceberg-rust/pull/611 2. https://gith

Re: [PR] TableMetadataBuilder [iceberg-rust]

c-thiel commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2334785757 Thanks for your Feedback @liurenjie1024. This isn't really a refactoring of the builder, it's more a complete rewrite. The old builder allowed to create corrupt metadata in various way

Re: [PR] TableMetadataBuilder [iceberg-rust]

liurenjie1024 commented on PR #587: URL: https://github.com/apache/iceberg-rust/pull/587#issuecomment-2333006736 Thanks @c-thiel for this pr, I've skimmed through it and it looks great to me. However this pr is too huge to review(3k lines), would you mind to split them into smaller onces? F