c-thiel commented on code in PR #587:
URL: https://github.com/apache/iceberg-rust/pull/587#discussion_r1850728077
##########
crates/iceberg/src/spec/schema.rs:
##########
@@ -376,6 +375,24 @@ impl Schema {
pub fn accessor_by_field_id(&self, field_id: i32) ->
Option<Arc<StructAccessor>> {
self.field_id_to_accessor.get(&field_id).cloned()
}
+
+ /// Check if this schema is identical to another schema semantically -
excluding schema id.
+ pub(crate) fn is_same_schema(&self, other: &SchemaRef) -> bool {
Review Comment:
I thought about this as well, but opted for a method with documentation.
This method excludes the `schema_id` which I can describe here in the
docstring. Using `Eq` I would expect the `schema_id` to be equal too -
especially because its used in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
