Fokko merged PR #200:
URL: https://github.com/apache/iceberg-python/pull/200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
HonahX commented on code in PR #200:
URL: https://github.com/apache/iceberg-python/pull/200#discussion_r1421997549
##
pyiceberg/table/__init__.py:
##
@@ -540,18 +540,38 @@ def update_table_metadata(base_metadata: TableMetadata,
updates: Tuple[TableUpda
class TableRequirement(I
Fokko commented on code in PR #200:
URL: https://github.com/apache/iceberg-python/pull/200#discussion_r1421948214
##
pyiceberg/table/__init__.py:
##
@@ -540,18 +540,38 @@ def update_table_metadata(base_metadata: TableMetadata,
updates: Tuple[TableUpda
class TableRequirement(Ic
HonahX commented on code in PR #200:
URL: https://github.com/apache/iceberg-python/pull/200#discussion_r1421918011
##
pyiceberg/table/refs.py:
##
@@ -34,6 +34,10 @@ def __repr__(self) -> str:
"""Return the string representation of the SnapshotRefType class."""
HonahX commented on code in PR #200:
URL: https://github.com/apache/iceberg-python/pull/200#discussion_r1421918011
##
pyiceberg/table/refs.py:
##
@@ -34,6 +34,10 @@ def __repr__(self) -> str:
"""Return the string representation of the SnapshotRefType class."""
HonahX commented on code in PR #200:
URL: https://github.com/apache/iceberg-python/pull/200#discussion_r1421918011
##
pyiceberg/table/refs.py:
##
@@ -34,6 +34,10 @@ def __repr__(self) -> str:
"""Return the string representation of the SnapshotRefType class."""
HonahX commented on code in PR #200:
URL: https://github.com/apache/iceberg-python/pull/200#discussion_r1421918011
##
pyiceberg/table/refs.py:
##
@@ -34,6 +34,10 @@ def __repr__(self) -> str:
"""Return the string representation of the SnapshotRefType class."""
HonahX opened a new pull request, #200:
URL: https://github.com/apache/iceberg-python/pull/200
This PR is the second part of #140
It implements a `validate` method for each table requirement. This method
raises a `CommitFailedException` with an appropriate error message if the
table
