HonahX commented on code in PR #200:
URL: https://github.com/apache/iceberg-python/pull/200#discussion_r1421918011
##########
pyiceberg/table/refs.py:
##########
@@ -34,6 +34,10 @@ def __repr__(self) -> str:
"""Return the string representation of the SnapshotRefType class."""
return f"SnapshotRefType.{self.name}"
+ def __str__(self) -> str:
+ """Return the string representation of the SnapshotRefType class."""
+ return self.value
Review Comment:
Seems we need this `__str__`. Otherwise,
```
>>> ref_type=SnapshotRefType.Branch
>>>f"Test: {ref_type}"
```
will show `Test: SnapshotRefType.Branch` in my local environment (Python
3.11) but `Test: branch` in CI's python 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
