Re: [PR] Support merge manifests on writes [iceberg-python]

2024-02-19 Thread via GitHub
HonahX commented on code in PR #363: URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1495367348 ## pyiceberg/table/__init__.py: ## @@ -944,7 +949,8 @@ def append(self, df: pa.Table) -> None: if len(self.spec().fields) > 0: raise ValueErro

Re: [PR] Support merge manifests on writes [iceberg-python]

2024-02-08 Thread via GitHub
Fokko commented on code in PR #363: URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1482859941 ## pyiceberg/table/__init__.py: ## @@ -944,7 +949,8 @@ def append(self, df: pa.Table) -> None: if len(self.spec().fields) > 0: raise ValueError

Re: [PR] Support merge manifests on writes [iceberg-python]

2024-02-05 Thread via GitHub
HonahX commented on code in PR #363: URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1479215719 ## pyiceberg/table/__init__.py: ## @@ -2411,11 +2428,29 @@ def _fetch_existing_manifests() -> List[ManifestFile]: executor = ExecutorFactory.get_or_creat

Re: [PR] Support merge manifests on writes [iceberg-python]

2024-02-05 Thread via GitHub
Fokko commented on code in PR #363: URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1478849196 ## pyiceberg/table/__init__.py: ## @@ -2411,11 +2428,29 @@ def _fetch_existing_manifests() -> List[ManifestFile]: executor = ExecutorFactory.get_or_create