Fokko commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1482859941
##########
pyiceberg/table/__init__.py:
##########
@@ -944,7 +949,8 @@ def append(self, df: pa.Table) -> None:
if len(self.spec().fields) > 0:
raise ValueError("Cannot write to partitioned tables")
- merge = _MergingSnapshotProducer(operation=Operation.APPEND,
table=self)
+ # TODO: need to consider how to support both _MergeAppend and
_FastAppend
Review Comment:
Do we really want to support both? This part of the Java code has been a
major source of (hard to debug) problems. Splitting out the commit and
compaction path completely would simplify that quite a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
