HonahX merged PR #498:
URL: https://github.com/apache/iceberg-python/pull/498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
HonahX commented on PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#issuecomment-2036194320
Thanks @Fokko @syun64 for detailed reviewing! Since this PR
changes/refactors lots of code, I'll merge this first and leave other works
(such as supporting createTableTrans in Hive an
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1550918541
##
pyiceberg/table/__init__.py:
##
@@ -760,7 +852,10 @@ def update_table_metadata(base_metadata: TableMetadata,
updates: Tuple[TableUpda
for update in updates
Fokko commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1549581440
##
mkdocs/docs/api.md:
##
@@ -165,6 +165,25 @@ catalog.create_table(
)
```
+To create a table with some subsequent changes in a transaction:
Review Comment:
Fokko commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1549588018
##
pyiceberg/table/__init__.py:
##
@@ -760,7 +852,10 @@ def update_table_metadata(base_metadata: TableMetadata,
updates: Tuple[TableUpda
for update in updates:
syun64 commented on PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#issuecomment-2033344103
> Shall we move "append", "overwrite", and "add_files" to `Transaction`
class? This change would enable us to seamlessly chain these operations with
other table updates in a single co
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1542411739
##
pyiceberg/catalog/rest.py:
##
@@ -524,7 +537,32 @@ def create_table(
except HTTPError as exc:
self._handle_non_200_response(exc, {409: Tabl
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1542406368
##
pyiceberg/catalog/__init__.py:
##
@@ -717,6 +791,10 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_properties
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1542411739
##
pyiceberg/catalog/rest.py:
##
@@ -524,7 +537,32 @@ def create_table(
except HTTPError as exc:
self._handle_non_200_response(exc, {409: Tabl
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1542411739
##
pyiceberg/catalog/rest.py:
##
@@ -524,7 +537,32 @@ def create_table(
except HTTPError as exc:
self._handle_non_200_response(exc, {409: Tabl
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1542411739
##
pyiceberg/catalog/rest.py:
##
@@ -524,7 +537,32 @@ def create_table(
except HTTPError as exc:
self._handle_non_200_response(exc, {409: Tabl
HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1542406368
##
pyiceberg/catalog/__init__.py:
##
@@ -717,6 +791,10 @@ def _get_updated_props_and_update_summary(
return properties_update_summary, updated_properties
syun64 commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1538156050
##
pyiceberg/catalog/__init__.py:
##
@@ -288,6 +291,78 @@ def __init__(self, name: str, **properties: str):
def _load_file_io(self, properties: Properties = EM
Fokko commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1537251443
##
pyiceberg/catalog/rest.py:
##
@@ -524,7 +537,32 @@ def create_table(
except HTTPError as exc:
self._handle_non_200_response(exc, {409: Table
14 matches
Mail list logo
