HonahX commented on code in PR #498:
URL: https://github.com/apache/iceberg-python/pull/498#discussion_r1542411739
##########
pyiceberg/catalog/rest.py:
##########
@@ -524,7 +537,32 @@ def create_table(
except HTTPError as exc:
self._handle_non_200_response(exc, {409: TableAlreadyExistsError})
- table_response = TableResponse(**response.json())
+ return TableResponse(**response.json())
+
+ @retry(**_RETRY_ARGS)
+ def _create_staged_table(
Review Comment:
Thanks! This is a great suggestion! After going through the current code, I
find that not only `_create_staged_table` but also most helper functions in
`Catalog` are specific to non-RestCatalog. Hence, I add a new class named
`MetastoreCatalog` (appreciate any suggestions on naming) and make all
non-RestCatalog inherit from it instead.
Since it is a big refactoring, please let me know if you want this to happen
in a follow-up PR.
##########
pyiceberg/catalog/rest.py:
##########
@@ -524,7 +537,32 @@ def create_table(
except HTTPError as exc:
self._handle_non_200_response(exc, {409: TableAlreadyExistsError})
- table_response = TableResponse(**response.json())
+ return TableResponse(**response.json())
+
+ @retry(**_RETRY_ARGS)
+ def _create_staged_table(
Review Comment:
Thanks! This is a great suggestion! After going through the current code, I
find that not only `_create_staged_table` but also most helper functions in
`Catalog` are specific to non-RestCatalog. Hence, I add a new class named
`MetastoreCatalog` (appreciate any suggestions on naming) and make all non-Rest
Catalogs inherit from it instead.
Since it is a big refactoring, please let me know if you want this to happen
in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
