Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-05 Thread via GitHub
amogh-jahagirdar merged PR #10835: URL: https://github.com/apache/iceberg/pull/10835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-05 Thread via GitHub
emkornfield commented on PR #10835: URL: https://github.com/apache/iceberg/pull/10835#issuecomment-2270162248 Could a committer merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-05 Thread via GitHub
emkornfield commented on PR #10835: URL: https://github.com/apache/iceberg/pull/10835#issuecomment-2270162084 [Vote passed](https://lists.apache.org/thread/44s6vkd9ky6x4ty2fyn9j7r7ylry6lgh) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-04 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1703358973 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-03 Thread via GitHub
findepi commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702807638 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data fil

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702365698 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702364798 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702358456 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
findepi commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702344833 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data fil

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702329275 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
findepi commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702327165 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data fil

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702313873 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702312741 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
findepi commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702311392 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data fil

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702310603 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702309561 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702309198 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
findepi commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702298836 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data fil

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702101794 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-02 Thread via GitHub
singhpk234 commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1702082433 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
ajantha-bhat commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1701294147 ## format/spec.md: ## @@ -241,7 +245,14 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg dat

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700892933 ## format/spec.md: ## @@ -241,7 +241,13 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700892556 ## format/spec.md: ## @@ -241,7 +241,13 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700892081 ## format/spec.md: ## @@ -1393,4 +1398,8 @@ This section covers topics not required by the specification but recommendations Iceberg supports two types of histo

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700892302 ## format/spec.md: ## @@ -591,11 +597,10 @@ For example, an `events` table with a timestamp column named `ts` that is partit Scan predicates are also used to

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
RussellSpitzer commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700687697 ## format/spec.md: ## @@ -1393,4 +1398,8 @@ This section covers topics not required by the specification but recommendations Iceberg supports two types of hi

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700687490 ## format/spec.md: ## @@ -241,7 +241,13 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700684796 ## format/spec.md: ## @@ -1393,4 +1398,8 @@ This section covers topics not required by the specification but recommendations Iceberg supports two types of histories

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
RussellSpitzer commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700684055 ## format/spec.md: ## @@ -1393,4 +1398,8 @@ This section covers topics not required by the specification but recommendations Iceberg supports two types of hi

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700681366 ## format/spec.md: ## @@ -591,11 +597,10 @@ For example, an `events` table with a timestamp column named `ts` that is partit Scan predicates are also used to filte

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700680980 ## format/spec.md: ## @@ -241,7 +241,13 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
rdblue commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700678608 ## format/spec.md: ## @@ -241,7 +241,13 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data file

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700443076 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700442621 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700442251 ## format/spec.md: ## @@ -399,6 +401,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associated

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
RussellSpitzer commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700381957 ## format/spec.md: ## @@ -399,6 +401,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associa

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
ajantha-bhat commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700375910 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
RussellSpitzer commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700372842 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg da

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
RussellSpitzer commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700364792 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg da

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
emkornfield commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1700342500 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
ajantha-bhat commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1699922544 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
ajantha-bhat commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1699922544 ## format/spec.md: ## @@ -241,7 +241,9 @@ Struct evolution requires the following rules for default values: Column Projection -Columns in Iceberg data

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-08-01 Thread via GitHub
ajantha-bhat commented on code in PR #10835: URL: https://github.com/apache/iceberg/pull/10835#discussion_r1699913512 ## format/spec.md: ## @@ -399,6 +401,9 @@ Sorting floating-point numbers should produce the following behavior: `-NaN` < ` A data or delete file is associate

Re: [PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-07-31 Thread via GitHub
emkornfield commented on PR #10835: URL: https://github.com/apache/iceberg/pull/10835#issuecomment-2262121685 CC @rdblue @RussellSpitzer an alternative (or perhaps cleanup) would be to move column projection to be a subject of scan-planning. I think this would flow more nicely since all of

[PR] Spec: Clarify identity partition edge cases. [iceberg]

2024-07-31 Thread via GitHub
emkornfield opened a new pull request, #10835: URL: https://github.com/apache/iceberg/pull/10835 Discussion on mailing list: https://lists.apache.org/thread/hss83r1605r8932b94xv9y2wfb9o0yns. -- This is an automated message from the Apache Git Service. To respond to the message, please log