Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-05 Thread via GitHub
aokolnychyi merged PR #9563: URL: https://github.com/apache/iceberg/pull/9563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-05 Thread via GitHub
aokolnychyi commented on PR #9563: URL: https://github.com/apache/iceberg/pull/9563#issuecomment-1927759989 Thanks, @advancedxy @rdblue! I am going to test this with our RC on a cluster. I can't cover everything locally. I tested the initial prototype on a cluster and it worked well. --

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-02 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1476914683 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-02 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1476899638 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java: ## @@ -331,4 +331,24 @@ private long driverMaxResultSize() { SparkConf sparkConf

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-02 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1476899638 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java: ## @@ -331,4 +331,24 @@ private long driverMaxResultSize() { SparkConf sparkConf

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-02 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1476795233 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-02 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1476795233 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-02 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1476443719 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
advancedxy commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1475446827 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
advancedxy commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1475440771 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMergeOnReadDelete.java: ## @@ -85,6 +86,30 @@ public static void clearTestSparkC

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
advancedxy commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1475438902 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java: ## @@ -331,4 +331,24 @@ private long driverMaxResultSize() { SparkConf sparkConf

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474861017 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474860162 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474842991 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474850481 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMergeOnReadDelete.java: ## @@ -85,6 +86,30 @@ public static void clearTestSpark

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474842991 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
aokolnychyi commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474841847 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Spark 3.5: Support executor cache locality [iceberg]

2024-02-01 Thread via GitHub
advancedxy commented on code in PR #9563: URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474613749 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPlanningUtil.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF