aokolnychyi commented on code in PR #9563:
URL: https://github.com/apache/iceberg/pull/9563#discussion_r1474850481
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMergeOnReadDelete.java:
##########
@@ -85,6 +86,30 @@ public static void clearTestSparkCatalogCache() {
TestSparkCatalog.clearTables();
}
+ @Test
+ public void testDeleteWithExecutorCacheLocality() throws
NoSuchTableException {
+ createAndInitPartitionedTable();
+
+ append(tableName, new Employee(1, "hr"), new Employee(2, "hr"));
+ append(tableName, new Employee(3, "hr"), new Employee(4, "hr"));
+ append(tableName, new Employee(1, "hardware"), new Employee(2,
"hardware"));
+ append(tableName, new Employee(3, "hardware"), new Employee(4,
"hardware"));
+
+ createBranchIfNeeded();
+
+ withSQLConf(
+ ImmutableMap.of(SparkSQLProperties.EXECUTOR_CACHE_LOCALITY_ENABLED,
"true"),
+ () -> {
+ sql("DELETE FROM %s WHERE id = 1", commitTarget());
+ sql("DELETE FROM %s WHERE id = 3", commitTarget());
+
+ assertEquals(
Review Comment:
I am afraid we can't really test this as `SparkUtil$executorLocations` would
return an empty list in our local testing env. This test is to simply ensure
nothing breaks if run on the driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
