Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-10-28 Thread via GitHub
Fokko merged PR #10811: URL: https://github.com/apache/iceberg/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-09-11 Thread via GitHub
nastra commented on code in PR #10811: URL: https://github.com/apache/iceberg/pull/10811#discussion_r1754328006 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java: ## @@ -419,5 +421,13 @@ public void testFaultToleranceOnWrite() throws IOEx

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-09-11 Thread via GitHub
manuzhang commented on PR #10811: URL: https://github.com/apache/iceberg/pull/10811#issuecomment-2343454242 cc @nastra help review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-08-28 Thread via GitHub
manuzhang commented on PR #10811: URL: https://github.com/apache/iceberg/pull/10811#issuecomment-2316566447 @Fokko @dramaticlly PTAL. This PR now proactively deletes temporary directory catching exceptions until it's cleaned up. -- This is an automated message from the Apache Git Service.

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-08-28 Thread via GitHub
manuzhang closed pull request #10811: Spark 3.5: Fix flaky test due to deleting temp directory failure URL: https://github.com/apache/iceberg/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-30 Thread via GitHub
manuzhang commented on PR #10811: URL: https://github.com/apache/iceberg/pull/10811#issuecomment-2257733586 This PR didn't fix but exposed more underlying errors from https://github.com/apache/iceberg/actions/runs/10156307633/job/28084490263?pr=10811 ``` TestDataFrameWrites > testFault

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
manuzhang closed pull request #10811: Spark 3.5: Fix flaky test due to deleting temp directory failure URL: https://github.com/apache/iceberg/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
manuzhang closed pull request #10811: Spark 3.5: Fix flaky test due to deleting temp directory failure URL: https://github.com/apache/iceberg/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
manuzhang closed pull request #10811: Spark 3.5: Fix flaky test due to deleting temp directory failure URL: https://github.com/apache/iceberg/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
manuzhang commented on code in PR #10811: URL: https://github.com/apache/iceberg/pull/10811#discussion_r1696191123 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java: ## @@ -419,5 +420,8 @@ public void testFaultToleranceOnWrite() throws IO

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
manuzhang commented on code in PR #10811: URL: https://github.com/apache/iceberg/pull/10811#discussion_r1696191123 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java: ## @@ -419,5 +420,8 @@ public void testFaultToleranceOnWrite() throws IO

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
manuzhang commented on code in PR #10811: URL: https://github.com/apache/iceberg/pull/10811#discussion_r1696191123 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java: ## @@ -419,5 +420,8 @@ public void testFaultToleranceOnWrite() throws IO

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
RussellSpitzer commented on code in PR #10811: URL: https://github.com/apache/iceberg/pull/10811#discussion_r1695694630 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java: ## @@ -419,5 +420,8 @@ public void testFaultToleranceOnWrite() thro

Re: [PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
dramaticlly commented on code in PR #10811: URL: https://github.com/apache/iceberg/pull/10811#discussion_r1695524219 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java: ## @@ -419,5 +420,8 @@ public void testFaultToleranceOnWrite() throws

[PR] Spark 3.5: Fix flaky test due to deleting temp directory failure [iceberg]

2024-07-29 Thread via GitHub
manuzhang opened a new pull request, #10811: URL: https://github.com/apache/iceberg/pull/10811 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,