manuzhang commented on code in PR #10811:
URL: https://github.com/apache/iceberg/pull/10811#discussion_r1696191123


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java:
##########
@@ -419,5 +420,8 @@ public void testFaultToleranceOnWrite() throws IOException {
 
     
assertThat(snapshotBeforeFailingWrite).isEqualTo(snapshotAfterFailingWrite);
     assertThat(resultBeforeFailingWrite).isEqualTo(resultAfterFailingWrite);
+
+    FileUtils.deleteDirectory(location);

Review Comment:
   >     java.io.IOException: Failed to delete temp directory 
/tmp/junit8883793498240284997. The following paths could not be deleted (see 
suppressed exceptions for details): 
parquet/test/data/00001-127-9abadc06-9aa2-4b3b-8e77-66af8ddb7a3e-0-00001.parquet
   
   The flakiness is because table data cannot be deleted sometimes. This PR 
ensures deleting table data before temp directory cleaning up itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to