Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-08 Thread via GitHub
dramaticlly commented on PR #11929: URL: https://github.com/apache/iceberg/pull/11929#issuecomment-2644728252 Thanks you @szehon-ho ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-08 Thread via GitHub
szehon-ho commented on PR #11929: URL: https://github.com/apache/iceberg/pull/11929#issuecomment-2644727999 Merged, thanks @dramaticlly ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-08 Thread via GitHub
szehon-ho merged PR #11929: URL: https://github.com/apache/iceberg/pull/11929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-07 Thread via GitHub
szehon-ho commented on code in PR #11929: URL: https://github.com/apache/iceberg/pull/11929#discussion_r1947406948 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java: ## @@ -350,18 +352,47 @@ private RewriteResult rewriteVersionF

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-07 Thread via GitHub
szehon-ho commented on code in PR #11929: URL: https://github.com/apache/iceberg/pull/11929#discussion_r1947405782 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java: ## @@ -350,18 +352,47 @@ private RewriteResult rewriteVersionF

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-07 Thread via GitHub
szehon-ho commented on code in PR #11929: URL: https://github.com/apache/iceberg/pull/11929#discussion_r1947405782 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java: ## @@ -350,18 +352,47 @@ private RewriteResult rewriteVersionF

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-07 Thread via GitHub
dramaticlly commented on PR #11929: URL: https://github.com/apache/iceberg/pull/11929#issuecomment-2644361070 Not stale, will rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-02-07 Thread via GitHub
github-actions[bot] commented on PR #11929: URL: https://github.com/apache/iceberg/pull/11929#issuecomment-2644360203 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-01-08 Thread via GitHub
dramaticlly commented on code in PR #11929: URL: https://github.com/apache/iceberg/pull/11929#discussion_r1907943810 ## core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java: ## @@ -126,8 +126,7 @@ public static TableMetadata replacePaths( metadata.snapshotLog

Re: [PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-01-08 Thread via GitHub
flyrain commented on code in PR #11929: URL: https://github.com/apache/iceberg/pull/11929#discussion_r1907927060 ## core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java: ## @@ -126,8 +126,7 @@ public static TableMetadata replacePaths( metadata.snapshotLog(),

[PR] Spark: support statistics files in RewriteTablePath [iceberg]

2025-01-08 Thread via GitHub
dramaticlly opened a new pull request, #11929: URL: https://github.com/apache/iceberg/pull/11929 Statistics files are helpful to determine the NDV for each columns in a table and can be collected via engines like [trino](https://trino.io/docs/current/connector/iceberg.html#updating-table-st