szehon-ho commented on code in PR #11929:
URL: https://github.com/apache/iceberg/pull/11929#discussion_r1947406948
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -350,18 +352,47 @@ private RewriteResult<Snapshot>
rewriteVersionFiles(TableMetadata endMetadata) {
new StaticTableOperations(versionFilePath, table.io()).current();
result.toRewrite().addAll(tableMetadata.snapshots());
- result.copyPlan().add(rewriteVersionFile(tableMetadata,
versionFilePath));
+ result.copyPlan().addAll(rewriteVersionFile(tableMetadata,
versionFilePath));
}
return result;
}
- private Pair<String, String> rewriteVersionFile(TableMetadata metadata,
String versionFilePath) {
+ private Set<Pair<String, String>> rewriteVersionFile(
Review Comment:
Nit: how about having these just return Result as well for self
documentation of return value? Can be empty toRewrite(), but just copyPlan()?
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -350,18 +352,47 @@ private RewriteResult<Snapshot>
rewriteVersionFiles(TableMetadata endMetadata) {
new StaticTableOperations(versionFilePath, table.io()).current();
result.toRewrite().addAll(tableMetadata.snapshots());
- result.copyPlan().add(rewriteVersionFile(tableMetadata,
versionFilePath));
+ result.copyPlan().addAll(rewriteVersionFile(tableMetadata,
versionFilePath));
}
return result;
}
- private Pair<String, String> rewriteVersionFile(TableMetadata metadata,
String versionFilePath) {
+ private Set<Pair<String, String>> rewriteVersionFile(
+ TableMetadata metadata, String versionFilePath) {
+ Set<Pair<String, String>> result = Sets.newHashSet();
String stagingPath = RewriteTablePathUtil.stagingPath(versionFilePath,
stagingDir);
TableMetadata newTableMetadata =
RewriteTablePathUtil.replacePaths(metadata, sourcePrefix,
targetPrefix);
TableMetadataParser.overwrite(newTableMetadata,
table.io().newOutputFile(stagingPath));
- return Pair.of(stagingPath, newPath(versionFilePath, sourcePrefix,
targetPrefix));
+ result.add(Pair.of(stagingPath, newPath(versionFilePath, sourcePrefix,
targetPrefix)));
+
+ // include statistics files in copy plan
+ result.addAll(
+ copyPlanStatisticsFiles(metadata.statisticsFiles(),
newTableMetadata.statisticsFiles()));
+ return result;
+ }
+
+ private Set<Pair<String, String>> copyPlanStatisticsFiles(
Review Comment:
how about 'puffinFileCopyPlan' ? currently it sounds like a verb , ie this
method will copy something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
