Re: [PR] Spark: Improvements around test initialization [iceberg]

2024-04-12 Thread via GitHub
amogh-jahagirdar merged PR #10131: URL: https://github.com/apache/iceberg/pull/10131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Spark: Improvements around test initialization [iceberg]

2024-04-12 Thread via GitHub
amogh-jahagirdar commented on code in PR #10131: URL: https://github.com/apache/iceberg/pull/10131#discussion_r1562913308 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -73,7 +73,7 @@ public static void dropWarehouse() throws IOExcepti

Re: [PR] Spark: Improvements around test initialization [iceberg]

2024-04-12 Thread via GitHub
nastra commented on code in PR #10131: URL: https://github.com/apache/iceberg/pull/10131#discussion_r1562748933 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java: ## @@ -48,6 +46,4 @@ protected static Object[][] parameters() { } }; }

Re: [PR] Spark: Improvements around test initialization [iceberg]

2024-04-12 Thread via GitHub
nastra commented on code in PR #10131: URL: https://github.com/apache/iceberg/pull/10131#discussion_r1562743988 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java: ## @@ -57,6 +58,8 @@ public static void startMetastoreAndSpar